Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AsyncImageView to AsyncImageKit #23938

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 2, 2025

This PR slightly changed the relationship between MediaHost and MediaRequestAuthenticator to allow ImageDownloader.shared and other related types to finally be moved to the module.

This change is a prerequisite for updating the shared extensions with proper image loading and fixing a couple of known issues there.

No functional changes.

Changes:

  • Remove MediaHost from AsyncImageKit
  • Move ImageDownloader.shared to AsyncImageKit
  • Move AsyncImageView and other related types to AsyncImageKit.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Media label Jan 2, 2025
@kean kean added this to the 25.7 milestone Jan 2, 2025
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@kean kean merged commit 2c17896 into christmas-feature-branch Jan 2, 2025
0 of 2 checks passed
@kean kean deleted the task/media-authentificator branch January 2, 2025 23:28
@kean kean mentioned this pull request Jan 2, 2025
14 tasks
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23938-90b1166
Version25.6
Bundle IDorg.wordpress.alpha
Commit90b1166
App Center BuildWPiOS - One-Offs #11255
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23938-90b1166
Version25.6
Bundle IDcom.jetpack.alpha
Commit90b1166
App Center Buildjetpack-installable-builds #10292
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants